Use PATH env variable when gcc found in PATH #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the github issue ARMmbed#3790: Blinky fails to build (on Mac) after addition of linker script preprocessing feature. Paraphrasing, this issue is that Homebrew on mac does not install `arm-none-eabi-gcc` in the same location as `arm-none-eabi-cpp`, the C Pre-Processor. The tools prior to this commit, and after turning on the pre-processing of the linker-script will fail on any Mac homebrew installed toolchains. This commit resolves the above issue by allowing the toolchain's path to the executable to remain empty after a call to `check_executable`. When this path is empty, the tools will search the PATH environment variable for the executable.
|
cc @Patater |
Expected to come as part of this PR? |
|
@0xc0170 Yes. |
|
@0xc0170 Unit test added. |
|
I tested this out to verify that it fixes my problem, and hey, it does! Thanks a lot! |
|
Thanks for testing it @Patater! We now have a regression test in this PR, so once it's merged we should not be allowed to merge code that breaks this behavior. |
|
retest uvisor |
|
/morph test |
0xc0170
approved these changes
Mar 9, 2017
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
retest uvisor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the github issue #3790: Blinky fails to build (on Mac) after
addition of linker script preprocessing feature. Paraphrasing, this
issue is that Homebrew on mac does not install
arm-none-eabi-gccinthe same location as
arm-none-eabi-cpp, the C Pre-Processor. The toolsprior to this commit, and after turning on the pre-processing of the
linker-script will fail on any Mac homebrew installed toolchains.
This commit resolves the above issue by allowing the toolchain's path to
the executable to remain empty after a call to
check_executable. Whenthis path is empty, the tools will search the PATH environment variable
for the executable.
TODO